Fix: Add toLowerCase in plugin address comparison (#311)

* add toLowerCase * fix tests
aragon · Nov 30, 2023 · e8e3b6d · e8e3b6d
1 parent 1a4657d
commit e8e3b6d
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/modules/client/CHANGELOG.md b/modules/client/CHANGELOG.md
@@ -19,6 +19,10 @@ TEMPLATE:
 
 ## [UPCOMING]
 
+- Fixed pluginAddress comparison in `validatePluginUpdateProposal`
+
+## [1.20.0]
+
 ### Fixed
 
 - Added missing security check that checks that the `to` address in the permission actions is the DAO address

diff --git a/modules/client/package.json b/modules/client/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@aragon/sdk-client",
   "author": "Aragon Association",
-  "version": "1.20.0",
+  "version": "1.20.1",
   "license": "MIT",
   "main": "dist/index.js",
   "module": "dist/sdk-client.esm.js",

diff --git a/modules/client/src/internal/utils.ts b/modules/client/src/internal/utils.ts
@@ -1158,7 +1158,7 @@ export async function validateApplyUpdateFunction(
   // find the plugin with the same address
   const plugin = dao.plugins.find((plugin) =>
     plugin.appliedPreparation?.pluginAddress ===
-      decodedParams.pluginAddress
+      decodedParams.pluginAddress.toLowerCase()
   );
   if (!plugin) {
     causes.push(PluginUpdateProposalInValidityCause.PLUGIN_NOT_INSTALLED);

diff --git a/modules/client/test/integration/client/methods.test.ts b/modules/client/test/integration/client/methods.test.ts
@@ -1908,7 +1908,7 @@ describe("Client", () => {
           createdAt: "1234567890",
           plugins: [{
             appliedPreparation: {
-              pluginAddress: pluginAddress,
+              pluginAddress: pluginAddress.toLowerCase(),
             },
             appliedPluginRepo: {
               subdomain: SupportedPluginRepo.TOKEN_VOTING,