Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Plugin Update Security Check #301

Merged
merged 40 commits into from
Nov 23, 2023
Merged

refactor: Plugin Update Security Check #301

merged 40 commits into from
Nov 23, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Nov 7, 2023 •
edited by heueristik
Loading

Description

Tasks: OS-813, OS-835
This PR also contains the documentation page to be linked in the frontend: OS-834

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@josemarinas josemarinas added client-release Publishes the current version of client subpackage on NPM client-common-release Releases a new version of the client-common package labels Nov 7, 2023
Rekard0
Rekard0 reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from what Mathias pointed out, LGTM!

heueristik
heueristik suggested changes Nov 7, 2023
View reviewed changes
modules/client/src/internal/client/encoding.ts Outdated Show resolved Hide resolved
modules/client/CHANGELOG.md Outdated Show resolved Hide resolved
modules/client/CHANGELOG.md Outdated Show resolved Hide resolved
@heueristik
Copy link
Contributor

heueristik commented Nov 22, 2023 •
edited
Loading

How will the check behave if subgraph is down/not synced? We will return PROPOSAL_NOT_FOUND, right?

mathewmeconry
mathewmeconry suggested changes Nov 23, 2023
View reviewed changes
docs/sdk/03-update-security-check/index.md Outdated Show resolved Hide resolved
docs/sdk/03-update-security-check/index.md Outdated Show resolved Hide resolved
@heueristik @mathewmeconry
docs: fix typos
39dfc6d 
Co-authored-by: Mathias Scherer <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
9.4% 9.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@josemarinas josemarinas merged commit 2588415 into develop Nov 23, 2023
@josemarinas josemarinas deleted the f/OS-813-fix-plugin-upgrade-execution branch November 23, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 left review comments

@mathewmeconry mathewmeconry mathewmeconry approved these changes

@heueristik heueristik heueristik approved these changes

Assignees
No one assigned
Labels
client-common-release Releases a new version of the client-common package client-release Publishes the current version of client subpackage on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josemarinas @mathewmeconry @heueristik @Rekard0