Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX-128-audit-dev-portal-sdk-client #318

Merged
merged 7 commits into from
Feb 13, 2024
Merged

DX-128-audit-dev-portal-sdk-client #318

merged 7 commits into from
Feb 13, 2024

Conversation

pythonpete32
Copy link
Contributor

@pythonpete32 pythonpete32 commented Jan 8, 2024 •
edited by jira bot
Loading

Description

update SDK base client docs

Task ID: DX-128

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@CLAassistant
Copy link

CLAassistant commented Feb 12, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@banasa44 banasa44 force-pushed the DX-128-audit-dev-portal-sdk-client branch from 496c54e to e58ed91 Compare February 12, 2024 15:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Rekard0
Rekard0 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@banasa44 banasa44 merged commit a96e619 into develop Feb 13, 2024
9 checks passed
@banasa44 banasa44 deleted the DX-128-audit-dev-portal-sdk-client branch February 13, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@banasa44 banasa44 banasa44 approved these changes

@josemarinas josemarinas Awaiting requested review from josemarinas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pythonpete32 @CLAassistant @Rekard0 @banasa44 @josemarinas