Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: APP-3038 - update return type of proposal approver, grab address directly #331

Merged
merged 5 commits into from
Apr 9, 2024
Merged

fix: APP-3038 - update return type of proposal approver, grab address directly #331

merged 5 commits into from
Apr 9, 2024

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Apr 3, 2024 •
edited by jira bot
Loading

Description

update return type of proposal approver, grab address directly)

Task ID: APP-3038

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@josemarinas josemarinas added the client-release Publishes the current version of client subpackage on NPM label Apr 9, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@josemarinas josemarinas merged commit 225e74b into develop Apr 9, 2024
8 checks passed
@josemarinas josemarinas deleted the fix/APP-3038 branch April 9, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordaniza jordaniza jordaniza approved these changes

Assignees
No one assigned
Labels
client-release Publishes the current version of client subpackage on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thekidnamedkd @jordaniza @josemarinas