Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predict and interpret adaptation to data class #586

Merged

Conversation

camillebrianceau
Copy link
Collaborator

@camillebrianceau camillebrianceau commented May 22, 2024

For now, leave the architecture like:

config
    config
        pipelines
    options

but it will be changed in the next PR.

Other changes:

  • check_gpuis now a validator of ComputationalConfig
  • New PredictConfig and InterpretConfig
  • TrainingConfig -> TrainConfig
  • Adapt options of Interpret and Predict

@camillebrianceau camillebrianceau added the refactoring ClinicaDL refactoring 2024 label May 22, 2024
@camillebrianceau camillebrianceau marked this pull request as draft May 23, 2024 13:13
thibaultdvx and others added 4 commits May 29, 2024 10:47
* use config classes in trainer and makes the appropriate changes in classification, regression, reconstruction, from_json, resume and random-search
* use config classes in trainer and make the appropriate changes in classification, regression, reconstruction, from_json, resume and random-search

---------

Co-authored-by: thibaultdvx <[email protected]>
@pep8speaks
Copy link

pep8speaks commented May 29, 2024

Hello @camillebrianceau! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-05-29 16:56:38 UTC

@camillebrianceau camillebrianceau marked this pull request as ready for review May 29, 2024 16:54
Copy link
Collaborator

@thibaultdvx thibaultdvx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @camillebrianceau

@camillebrianceau camillebrianceau merged commit c278622 into aramis-lab:refactoring May 30, 2024
12 checks passed
@camillebrianceau camillebrianceau deleted the cb_predict_adapt branch May 30, 2024 12:23
camillebrianceau added a commit to camillebrianceau/clinicadl that referenced this pull request May 30, 2024
* adapt predict and interpret to config classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring ClinicaDL refactoring 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants