-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Predict and interpret adaptation to data class #586
Merged
camillebrianceau
merged 18 commits into
aramis-lab:refactoring
from
camillebrianceau:cb_predict_adapt
May 30, 2024
Merged
Predict and interpret adaptation to data class #586
camillebrianceau
merged 18 commits into
aramis-lab:refactoring
from
camillebrianceau:cb_predict_adapt
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use config classes in trainer and makes the appropriate changes in classification, regression, reconstruction, from_json, resume and random-search
* use config classes in trainer and make the appropriate changes in classification, regression, reconstruction, from_json, resume and random-search --------- Co-authored-by: thibaultdvx <[email protected]>
Hello @camillebrianceau! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-05-29 16:56:38 UTC |
thibaultdvx
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @camillebrianceau
camillebrianceau
added a commit
to camillebrianceau/clinicadl
that referenced
this pull request
May 30, 2024
* adapt predict and interpret to config classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, leave the architecture like:
but it will be changed in the next PR.
Other changes:
check_gpu
is now a validator ofComputationalConfig
PredictConfig
andInterpretConfig
TrainingConfig
->TrainConfig