Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to add two flags to the pytest command lines to enable developers to run functional tests locally without changing the CI data:
--no-gpu
enables to run successfully a test on a cpu-only device without changinggpu
tofalse
in themaps.json
file.--adapt-base-dir
enables to run successfully a test without changing the paths in themaps.json
file.A developer could then run a test with something like:
poetry run pytest --verbose \ --basetemp=/tmp/train \ --input_data_directory=/Users/thibault.devarax/Desktop/code/clinicadl_data_ci/data_ci/ \ --no-gpu \ --adapt-base-dir \ tests/test_train_ae.py
These two options work by virtually modifying the CI data (e.g.
gpu
will be set tofalse
). So, I do agree that this is risky. But, I find this solution better than concretely modifying the CI data.Let me stress that these flags should not be used for the final CI tests run on GitHub and should be only helpful when a developer wants to run the tests locally.
Anyways, this is just a suggestion, so feel free to comment or offer other solutions. Once we agree on a solution, I will extend it to all the tests.