Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TaskManager #648

Merged

Conversation

camillebrianceau
Copy link
Collaborator

No description provided.

@camillebrianceau camillebrianceau marked this pull request as ready for review September 2, 2024 14:26
@pep8speaks
Copy link

pep8speaks commented Sep 3, 2024

Hello @camillebrianceau! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 84:13: E266 too many leading '#' for block comment

Comment last updated at 2024-09-11 14:41:46 UTC

Copy link
Collaborator

@thibaultdvx thibaultdvx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except a print!

@@ -32,6 +33,7 @@ def __init__(self, metrics, n_classes=2):
for method_name in dir(MetricModule)
if callable(getattr(MetricModule, method_name))
]
print(metrics)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it an oversight or is it on purpose?

@thibaultdvx thibaultdvx merged commit 574f7a0 into aramis-lab:refactoring Sep 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants