Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of BasicSerializeMessage in Alien #1986

Conversation

grospelliergilles
Copy link
Member

This class is internal to Arccore and should not be used directly.
Replace the following pattern:

auto x = BasicSerializeMessage::create(orig,dest,message_type);
message_list->addMessage(x);

with

message_list->createAndAddMessage(dist,message_type);

@grospelliergilles grospelliergilles added refactoring Code refactoring and cleanup alien Alien component labels Feb 15, 2025
@grospelliergilles grospelliergilles self-assigned this Feb 15, 2025
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.52%. Comparing base (e413c3b) to head (48f4d15).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1986      +/-   ##
==========================================
- Coverage   70.55%   70.52%   -0.04%     
==========================================
  Files        2286     2286              
  Lines      166971   166929      -42     
  Branches    19184    19184              
==========================================
- Hits       117808   117728      -80     
- Misses      42153    42191      +38     
  Partials     7010     7010              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles force-pushed the dev/gg-remove-direct-usage-of-basicserializemessage-in-alien branch from df5c92b to 48f4d15 Compare February 17, 2025 16:15
@grospelliergilles grospelliergilles merged commit e4b07eb into main Feb 17, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alien Alien component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants