Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove parent tile workaround #211

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jacobtylerwalls
Copy link
Member

This branch removes the workarounds for parent tile linking and the last custom serializers.

It works with the core branch I just pushed to support nested tile writes. I'll keep testing with cardinality N early next week(*) (which would just be an array), but this branch allows cardinality 1 like:

"right": {
    "right_statement": {
         "right_statement_content": "foo"
    }
}

Marking this PR as draft until I do that additional testing with cardinality N.

(*) And then honestly I'll be at the point where I can pull this out into an arches app and write some tests to get ready for a round of reviews. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant