Lint

src/_cleanup.js

@@ -26,7 +26,7 @@ module.exports = function cleanup (installed) {
           renameSync(join(dir, swap), join(dir, file))
         }
       }
-      catch (err) { null } // Swallow errors, we may have to bubble something else
+      catch { null } // Swallow errors, we may have to bubble something else
     })
   }
 }

src/_denoise.js

@@ -2,7 +2,7 @@
  * Filter out excessive / unhelpful vendor logging that includes any of the following strings
  */
 let strings = [
-  'npm WARN prepare removing existing node_modules/ before installation'
+  'npm WARN prepare removing existing node_modules/ before installation',
 ]
 let regexes = [
   /npm WARN .* No description/g,

src/actions/autoinstall/node/get-root-deps.js

@@ -7,7 +7,7 @@ module.exports = function getRootDeps ({ inv }) {
   let packageJson = join(root, 'package.json')
   let packageLock = join(root, 'package-lock.json')
 
-  let package = existsSync(packageJson) && JSON.parse(readFileSync(packageJson)) || {}
+  let package = (existsSync(packageJson) && JSON.parse(readFileSync(packageJson))) || {}
   let deps = Object.assign(package.devDependencies || {}, package.dependencies || {})
 
   let lock = existsSync(packageLock) && JSON.parse(readFileSync(packageLock))

src/actions/autoinstall/node/index.js

@@ -120,7 +120,7 @@ module.exports = function treeshakeNode (nodeDirs, params) {
         dir,
         file: 'package.json',
         remove: [ 'package.json', 'package-lock.json' ], // Identify files for later removal
-        data: JSON.stringify(lambdaPackage, null, 2)
+        data: JSON.stringify(lambdaPackage, null, 2),
       }
       // Autoinstall can be called on a directory that contains a package.json with `"type": "module"` (and no dependencies)
       // If we find such a case, kindly move the existing package.json aside until autoinstall ops are complete

src/actions/autoinstall/python/get-root-requirements-config.js

@@ -5,8 +5,8 @@ module.exports = function getRootRequirementsConfig ({ inv }) {
   let root = inv._project.cwd
   let requirementsTxt = join(root, 'requirements.txt')
 
-  let requirements = existsSync(requirementsTxt) &&
-                     readFileSync(requirementsTxt).toString().split('\n') || []
+  let requirements = (existsSync(requirementsTxt) &&
+                      readFileSync(requirementsTxt).toString().split('\n')) || []
 
   let requirementsConfig = requirements.filter(r => r.startsWith('--')).join('\n') + '\n'
 

src/actions/autoinstall/python/index.js

@@ -60,7 +60,7 @@ ${requirementsConfig}${dependencies}
         dir,
         file: 'requirements.txt',
         remove: [ 'requirements.txt' ], // Identify files for later removal
-        data: lambdaRequirements
+        data: lambdaRequirements,
       }
       installing.push(params)
     }

src/actions/install-update.js

@@ -86,7 +86,6 @@ module.exports = function hydrator (params, callback) {
           prodFlag = isRoot ? '' : '--prod'
           let localPnpm
           try {
-            // eslint-disable-next-line
             require.resolve('pnpm')
             localPnpm = true
           }
@@ -97,7 +96,6 @@ module.exports = function hydrator (params, callback) {
         else if (isYarn) {
           let localYarn
           try {
-            // eslint-disable-next-line
             require.resolve('yarn')
             localYarn = true
           }
@@ -170,6 +168,6 @@ module.exports = function hydrator (params, callback) {
       else {
         callback()
       }
-    }
+    },
   ], callback)
 }

src/hydrate.js

@@ -53,7 +53,7 @@ function hydrator (inventory, installing, params, callback) {
     verbose,
     // Isolation / sandbox
     copyShared = true,
-    hydrateShared = true
+    hydrateShared = true,
   } = params
   let updaterParams = { quiet }
   let update = updater('Hydrate', updaterParams)
@@ -77,7 +77,6 @@ function hydrator (inventory, installing, params, callback) {
   /**
    * Find our dependency manifests
    */
-  // eslint-disable-next-line
   let pattern = p => pathToUnix(`${p}/**/@(${manifestFiles.join('|')})`)
   let dir = basepath || '.'
   // Get everything except shared
@@ -136,7 +135,7 @@ function hydrator (inventory, installing, params, callback) {
             let pkg = JSON.parse(readFileSync(join(src, 'package.json')))
             if (!pkg.dependencies && !pkg.peerDependencies && !pkg.devDependencies) return src
           }
-          catch (err) {
+          catch {
             update.error(`Invalid or unable to read ${src}${sep}package.json`)
           }
         }
@@ -182,7 +181,7 @@ function hydrator (inventory, installing, params, callback) {
       installing,
       update,
       inventory,
-      ...params
+      ...params,
     }, callback))
   })
 

test/integration/_shared.js

@@ -126,7 +126,7 @@ let pluginArtifacts = []
   .flat()
 
 let sharedArtifactsDisabled = [
-  join('src', 'http', 'any-time_is_good-catchall', nodeShared, 'shared.md')
+  join('src', 'http', 'any-time_is_good-catchall', nodeShared, 'shared.md'),
 ]
 
 // Represents src/views without @views pragma (i.e. all GET fns receive views)
@@ -145,7 +145,7 @@ let viewsArtifacts = []
   .concat(arcCustomPath.map(p => join(p, nodeShared, 'views.md')))
 
 let viewsArtifactsDisabled = [
-  join('src', 'http', 'any-time_is_good-catchall', nodeShared, 'views.md')
+  join('src', 'http', 'any-time_is_good-catchall', nodeShared, 'views.md'),
 ]
 
 

test/integration/default/install-tests.js

@@ -3,7 +3,7 @@ let {
   existsSync,
   mkdirSync,
   readFileSync,
-  writeFileSync
+  writeFileSync,
 } = require('fs')
 let test = require('tape')
 let {
@@ -116,7 +116,7 @@ test(`[Default (file copying)] install() hydrates all Functions', shared and vie
         let dependencies = {
           cpr: 'latest',
           'run-series': 'latest',
-          'tiny-json-http': 'latest'
+          'tiny-json-http': 'latest',
         }
         t.deepEqual(autoinstall._parsed, _parsed, 'Autoinstall walked shared + views')
         t.deepEqual(autoinstall.dependencies, dependencies, 'Autoinstall installed shared + views deps')
@@ -256,7 +256,7 @@ test(`[Default (file copying)] install() should not recurse into Functions depen
     mkdirSync(subdep, { recursive: true })
     writeFileSync(join(subdep, 'package.json'), JSON.stringify({
       name: 'poop',
-      dependencies: { 'tiny-json-http': '*' }
+      dependencies: { 'tiny-json-http': '*' },
     }), 'utf-8')
     let basepath = nodeFunctions[0]
     hydrate.install({ basepath }, function (err) {

test/integration/default/shared-tests.js

@@ -5,7 +5,7 @@ let {
   mkdirSync,
   readFileSync,
   renameSync,
-  writeFileSync
+  writeFileSync,
 } = require('fs')
 let cp = require('cpr')
 let test = require('tape')
@@ -63,7 +63,7 @@ test(`[Shared file copying (default paths)] shared() copies shared and views (un
     sharedArtifacts.length +
     getViewsArtifacts.length +
     sharedArtifactsDisabled.length +
-    viewsArtifactsDisabled.length + 1
+    viewsArtifactsDisabled.length + 1,
   )
   resetAndCopyShared(t, function () {
     hydrate.shared({}, function (err) {
@@ -99,7 +99,7 @@ test(`[Shared file copying with plugins (default paths)] shared() copies shared
     getViewsArtifacts.length +
     sharedArtifactsDisabled.length +
     viewsArtifactsDisabled.length +
-    pluginArtifacts.length + 1
+    pluginArtifacts.length + 1,
   )
   resetAndCopySharedPlugins(t, function () {
     cp(join('src', 'app.plugins'), join('.', 'app.arc'), { overwrite: true },
@@ -144,7 +144,7 @@ test(`[Shared file copying (custom paths)] shared() copies shared and views (unl
     sharedArtifacts.length +
     getViewsArtifacts.length +
     sharedArtifactsDisabled.length +
-    viewsArtifactsDisabled.length + 1
+    viewsArtifactsDisabled.length + 1,
   )
   resetAndCopySharedCustom(t, function () {
     hydrate.shared({}, function (err) {

test/integration/default/update-tests.js

@@ -19,7 +19,6 @@ test(`[Default (file copying)] update() bumps installed dependencies to newer ve
     hydrate.update(undefined, function (err) {
       if (err) t.fail(err)
       else {
-        // eslint-disable-next-line
         let pkgLock = JSON.parse(readFileSync(join(mockTmp, nodeFunctions[0], 'package-lock.json')))
         let newVersion = [ 2, 3 ].includes(pkgLock.lockfileVersion)
           ? pkgLock.packages['node_modules/tiny-json-http'].version

test/integration/symlink/install-tests.js

@@ -3,7 +3,7 @@ let {
   existsSync,
   mkdirSync,
   readFileSync,
-  writeFileSync
+  writeFileSync,
 } = require('fs')
 let test = require('tape')
 let {
@@ -120,7 +120,7 @@ test(`[Symlinking] install() hydrates all Functions', shared and views dependenc
         let dependencies = {
           cpr: 'latest',
           'run-series': 'latest',
-          'tiny-json-http': 'latest'
+          'tiny-json-http': 'latest',
         }
         t.deepEqual(autoinstall._parsed, _parsed, 'Autoinstall walked shared + views')
         t.deepEqual(autoinstall.dependencies, dependencies, 'Autoinstall installed shared + views deps')
@@ -260,7 +260,7 @@ test(`[Symlinking] install() should not recurse into Functions dependencies and
     mkdirSync(subdep, { recursive: true })
     writeFileSync(join(subdep, 'package.json'), JSON.stringify({
       name: 'poop',
-      dependencies: { 'tiny-json-http': '*' }
+      dependencies: { 'tiny-json-http': '*' },
     }), 'utf-8')
     let basepath = nodeFunctions[0]
     hydrate.install({ basepath, symlink }, function (err) {

test/integration/symlink/shared-tests.js

@@ -5,7 +5,7 @@ let {
   mkdirSync,
   readFileSync,
   renameSync,
-  writeFileSync
+  writeFileSync,
 } = require('fs')
 let cp = require('cpr')
 let test = require('tape')
@@ -67,7 +67,7 @@ test(`[Shared file symlinking (default paths)] shared() copies shared and views
     sharedArtifacts.length +
     getViewsArtifacts.length +
     sharedArtifactsDisabled.length +
-    viewsArtifactsDisabled.length + 1
+    viewsArtifactsDisabled.length + 1,
   )
   resetAndCopyShared(t, function () {
     hydrate.shared({ symlink }, function (err) {
@@ -103,7 +103,7 @@ test(`[Shared file symlinking with plugins (default paths)] shared() copies shar
     getViewsArtifacts.length +
     sharedArtifactsDisabled.length +
     viewsArtifactsDisabled.length +
-    pluginArtifacts.length + 1
+    pluginArtifacts.length + 1,
   )
   resetAndCopySharedPlugins(t, function () {
     cp(join('src', 'app.plugins'), join('.', 'app.arc'), { overwrite: true },
@@ -148,7 +148,7 @@ test(`[Shared file symlinking (custom paths)] shared() copies shared and views (
     sharedArtifacts.length +
     getViewsArtifacts.length +
     sharedArtifactsDisabled.length +
-    viewsArtifactsDisabled.length + 1
+    viewsArtifactsDisabled.length + 1,
   )
   resetAndCopySharedCustom(t, function () {
     hydrate.shared({ symlink }, function (err) {

test/integration/symlink/update-tests.js

@@ -25,7 +25,6 @@ test(`[Symlinking] update() bumps installed dependencies to newer versions`, t =
     hydrate.update({ symlink }, function (err) {
       if (err) t.fail(err)
       else {
-        // eslint-disable-next-line
         let pkgLock = JSON.parse(readFileSync(join(mockTmp, nodeFunctions[0], 'package-lock.json')))
         let newVersion = [ 2, 3 ].includes(pkgLock.lockfileVersion)
           ? pkgLock.packages['node_modules/tiny-json-http'].version

test/unit/src/shared/get-paths-tests.js

@@ -13,10 +13,10 @@ test('inventory with a shared path to hydrate and a single node runtime lambda a
       lambdasBySrcDir: {
         [path]: {
           name: 'get /items',
-          config: { runtime: 'nodejs12' }
-        }
-      }
-    }
+          config: { runtime: 'nodejs12' },
+        },
+      },
+    },
   }
   let paths = getPaths(inventory)
   t.equals(paths.all[path], join(path, 'node_modules', '@architect'), 'node runtime lambda returns node_modules path (all)')
@@ -33,15 +33,15 @@ test('inventory with a shared path to hydrate and a single non-node runtime lamb
   let inventory = {
     inv: {
       shared: {
-        shared: [ path ]
+        shared: [ path ],
       },
       lambdasBySrcDir: {
         [path]: {
           name: 'get /items',
-          config: { runtime: 'python3' }
-        }
-      }
-    }
+          config: { runtime: 'python3' },
+        },
+      },
+    },
   }
   let paths = getPaths(inventory)
   t.equals(paths.all[path], join(path, 'vendor'), 'non-node runtime lambda returns vendor path (all)')
@@ -58,16 +58,16 @@ test('inventory with a shared path to hydrate and multiple node runtime lambdas
   let inventory = {
     inv: {
       views: {
-        views: [ path ]
+        views: [ path ],
       },
       lambdasBySrcDir: {
         [path]: [
           { name: 'get /items', config: { runtime: 'nodejs12' } },
           { name: 'get /api/v1/items', config: { runtime: 'nodejs12' } },
           { name: 'get /api/v2/items', config: { runtime: 'nodejs12' } },
-        ]
-      }
-    }
+        ],
+      },
+    },
   }
   let paths = getPaths(inventory)
   t.equals(paths.all[path], join(path, 'node_modules', '@architect'), 'node runtime lambda returns node_modules path (all)')