Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Laravel 12 support #1321

Merged
merged 3 commits into from
Feb 25, 2025
Merged

[4.x] Laravel 12 support #1321

merged 3 commits into from
Feb 25, 2025

Conversation

stancl
Copy link
Member

@stancl stancl commented Feb 25, 2025

This PR adds Laravel 12 support and drops support for all other Laravel versions.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.74%. Comparing base (657e165) to head (9d86178).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1321   +/-   ##
=========================================
  Coverage     84.74%   84.74%           
- Complexity     1063     1071    +8     
=========================================
  Files           177      177           
  Lines          3100     3101    +1     
=========================================
+ Hits           2627     2628    +1     
  Misses          473      473           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stancl stancl marked this pull request as ready for review February 25, 2025 15:20
@stancl stancl merged commit 8960a83 into master Feb 25, 2025
11 checks passed
@stancl stancl deleted the v4-laravel-12 branch February 25, 2025 15:26
@Jacobtims
Copy link

@stancl Why did you drop support for Laravel 11?

@stancl
Copy link
Member Author

stancl commented Feb 26, 2025

It is easier to update the average app to Laravel 12 than for us to maintain compatibility with both L11 and L12.

@Jacobtims
Copy link

There are still a lot of other packages that don't support L12, Now I can't update my tenancy projects.

@stancl
Copy link
Member Author

stancl commented Feb 26, 2025

You can lock the tenancy version to an older commit that supports Laravel 11 and only switch back to dev-master when you can update your entire app. We'll soon be pushing changes that will likely depend on changes made to Laravel 12 — it would make no sense to support Laravel 11.

@Jacobtims
Copy link

Jacobtims commented Feb 26, 2025

When I lock it to an older commit, composer will still look at the latest composer.json. That doesn't work unfortunately...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants