Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add explicit nullable type declarations for UserImpersonation parameters #1324

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from
Open

fix: add explicit nullable type declarations for UserImpersonation parameters #1324

wants to merge 1 commit into from

Conversation

mu-hanz
Copy link

@mu-hanz mu-hanz commented Feb 27, 2025

This PR addresses deprecation warnings in UserImpersonation.php by adding explicit nullable type declarations.

Changes:

  • Added explicit ?string type for $authGuard parameter in bootstrap() method
  • Added explicit ?int type for $ttl parameter in makeResponse() method
  • Updated PHPDoc to reflect the nullable type for $ttl

Fixes deprecation warnings:

  • Implicitly marking parameter $authGuard as nullable is deprecated
  • Implicitly marking parameter $ttl as nullable is deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mu-hanz