Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(watermark): fontColor follows the theme #2790

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

oljc
Copy link
Member

@oljc oljc commented Nov 12, 2023

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

#2785
水印组件跟随主题变化

Solution

因为组件库相对固定的主题选择器body

通过观察器 useMutationObserver 来观察body上主题的变化来控制水印。并关闭了不必要的观察配置以最佳性能运作。

iShot_2023-11-12_14.46.38.mp4

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
watermark 水印字体色跟随主题变化 watermark font color follows the theme Close #2785

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@flsion flsion added the 🐛 Bug Something isn't working label Dec 22, 2023
@flsion flsion added this to the 2.54.1 milestone Dec 22, 2023
@flsion flsion added ✨ Feature Request New feature or request and removed 🐛 Bug Something isn't working labels Dec 22, 2023
@flsion flsion merged commit 8184d32 into arco-design:main Dec 22, 2023
@oljc oljc deleted the feat-watermark-theme branch February 2, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature Request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(watermark): 暗色模式水印字体颜色不变
2 participants