fix(switch): loading state can't be controlled with truthy initial state #3285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Background and context
如果给 Switch 组件的 loading 传入初始状态为 true 的 Ref,内部的 _loading 会被初始化为 true,此时如果外部的 loading 变回 false 则 Switch 组件仍会处于 loading 状态,导致组件的 loading 态不受控。
If you pass a Ref to the loading of the Switch component with an initial state of
true
, the internal ref_loading
will be initialized withtrue
, then if the external loading ref changed to false, the Switch component will still be in the loading state, resulting in an uncontrolled loading state.Solution
How is the change tested?
Changelog
Checklist:
npm run test
)feature
branch and othersshould be submitted to
main
branch)Other information