Stop vendoring the librashader header on Linux #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamically fetching code that we depend on in order to build is not a favorable pattern on Linux. As part of finishing migration to CMake, I plan to move the librashader headers (by themselves) back into the ares source tree, so that Linux users may build without depending on any code that comes from this repository.
This leads to a slightly larger maintenance overhead, in that we will have to remember to update the header in the ares source tree whenever we update librashader here, but it is ultimately a step in the right direction; this repository is designed to serve the needs of macOS and Windows users; Linux is a different ecosystem with its own patterns that need to be handled differently.