build: macOS toolchain fixups #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the regex used to determine our macOS SDK version to match on Command Line Tools install paths and not just Xcode install paths, since we do not require Xcode to build ares, just the Xcode Command Line Tools.
Also fixes up how we handle the macOS deployment target.
(boring details below)
CMake is meant to transparently derive and pass appropriate compiler options for our minimum deployment target. It does this via the
CMAKE_OSX_DEPLOYMENT_TARGETvariable. This variable can be initialized either by the project (which must happen before theproject()call), or else as part of theproject()call, CMake will inherit it from theMACOSX_DEPLOYMENT_TARGETenvironment variable, or else "compute it based on the host platform" (whatever that means).Our desired behavior is to set it to 10.13, except for local builds, where we should respect the MACOSX_DEPLOYMENT_TARGET environment variable (if it is set). This PR enables that behavior.