m32x+md fixes #1807
Merged
m32x+md fixes #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TascoDLX
commented
Feb 2, 2025
TascoDLX
commented
- Revised pwm emulation, mostly to align with documentation. Not likely to affect much except for rare edge cases. Also, added a dc filter to prevent audio popping in certain situations (like window losing focus), but pops on init are correct behavior. Fixes [Mega 32X] BC Racers. Sound Samples are not played back #937 by implementing byte-wide fifo writes from the SH2 side.
- Various fixups to 32x io access by the 68k. Fixes [MEGA CD-32X] Night Trap: video/sound stuttering #1196 and missing music in Brutal.
- Follow-up to a previous PR: cram dots were not limited properly, and line buffer adjustment was crashing 32x in certain cases (as reported in the discord).
LukeUsher
reviewed
Feb 2, 2025
ares/md/m32x/pwm.cpp
Outdated
| @@ -11,7 +10,8 @@ auto M32X::PWM::unload(Node::Object parent) -> void { | |||
| } | |||
|
|
|||
| auto M32X::PWM::main() -> void { | |||
| n12 clocks = cycle - 1; | |||
| int clocks = cycle > 0 ? cycle-1 : 4095; | |||
There was a problem hiding this comment.
This change shouldn’t have been necessary, if clocks was 0, being an n5 it should have underflowed and wrapped to 4095 anyway
There was a problem hiding this comment.
You are correct. I had changed this at some point but I guess it just wound up back where it started.
|
Added fix to pixel alignment between H32 and H40 modes. This is also follow-up to the previous PR where borders were added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.