Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clue replenishing to hotkey #771

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Added clue replenishing to hotkey #771

merged 5 commits into from
Jul 19, 2024

Conversation

Chr1Z93
Copy link
Collaborator

@Chr1Z93 Chr1Z93 commented Jul 14, 2024

  • now properly places clue tokens that are spawned with numpad 8
  • updated resource spawning for numpad 9

@Chr1Z93 Chr1Z93 added the enhancement New feature or request label Jul 14, 2024
@dscarpac
Copy link
Collaborator

Two issues I ran into:
(1a) With a clickable resource counter already on a card, moving a resource onto the card manually, and then hitting "9" removes the resource token but does not add to the count: e.g. "14" plus one resource token, then hitting "9" gives "15" on the counter, when 16 is expected. (Note that without the resource counter, this gives the expected behavior when manually adding a resource token.
(1b) When the use type is something else, like "charge", manually putting another charge onto a card that already has a clickable counter does not remove the charge token, unlike (1a)

(2) Adding more than ~16 clue tokens to a location causes all of the clues to vibrate and dance around on top of the card. Any more than 20 clues spawns them at the bottom left of the card instead. Perhaps we can convert these to clickable clue counters, just like the resource tokens?

@Chr1Z93
Copy link
Collaborator Author

Chr1Z93 commented Jul 16, 2024

(1a) With a clickable resource counter already on a card, moving a resource onto the card manually, and then hitting "9" removes the resource token but does not add to the count: e.g. "14" plus one resource token, then hitting "9" gives "15" on the counter, when 16 is expected. (Note that without the resource counter, this gives the expected behavior when manually adding a resource token.
(1b) When the use type is something else, like "charge", manually putting another charge onto a card that already has a clickable counter does not remove the charge token, unlike (1a)

I don't think it should be intended to combine existing resource tokens with a clickable counter. Imo the existing resource token should not get deleted, because the counter takes precedence. (Should be easy to add that)

(2) Adding more than ~16 clue tokens to a location causes all of the clues to vibrate and dance around on top of the card. Any more than 20 clues spawns them at the bottom left of the card instead. Perhaps we can convert these to clickable clue counters, just like the resource tokens?

I'd like to avoid having clickable clue counters on locations since that will effect a lot of other code (like "Take a clue" hotkey and VP counting). How about spawning >16 clues on top of the existing ones instead? Here's something related: #390

@dscarpac
Copy link
Collaborator

(1a) With a clickable resource counter already on a card, moving a resource onto the card manually, and then hitting "9" removes the resource token but does not add to the count: e.g. "14" plus one resource token, then hitting "9" gives "15" on the counter, when 16 is expected. (Note that without the resource counter, this gives the expected behavior when manually adding a resource token.
(1b) When the use type is something else, like "charge", manually putting another charge onto a card that already has a clickable counter does not remove the charge token, unlike (1a)

I don't think it should be intended to combine existing resource tokens with a clickable counter. Imo the existing resource token should not get deleted, because the counter takes precedence. (Should be easy to add that)

(2) Adding more than ~16 clue tokens to a location causes all of the clues to vibrate and dance around on top of the card. Any more than 20 clues spawns them at the bottom left of the card instead. Perhaps we can convert these to clickable clue counters, just like the resource tokens?

I'd like to avoid having clickable clue counters on locations since that will effect a lot of other code (like "Take a clue" hotkey and VP counting). How about spawning >16 clues on top of the existing ones instead? Here's something related: #390

I'm fine with your solution to (2), maybe wrapping up #390 in the process.

For (1), as long as these are consistent, that's much better, but I'm also thinking about ways to merge the clickable resource counters and tokens that get spawned in other ways, not just a manually placed resource or charge. For example, dealing with the tokens (or the single clickable resource counter) that spawn with Extra Ammunition and the like. If you move those tokens over to a weapon that already has tons of tokens on it, it'd be nice to accommodate that without the extra mess.

@dscarpac dscarpac merged commit ba8f6c9 into main Jul 19, 2024
1 check passed
@dscarpac dscarpac deleted the clue-replenishing branch July 19, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants