Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a fancier msm for halo2curves-related crates #193

Closed
huitseeker opened this issue Dec 18, 2023 · 0 comments · Fixed by #230
Closed

Implement a fancier msm for halo2curves-related crates #193

huitseeker opened this issue Dec 18, 2023 · 0 comments · Fixed by #230
Assignees
@winston-h-zhang
Labels
A-1 Proof Scaling

Comments

@huitseeker
Copy link
Member

huitseeker commented Dec 18, 2023 •
edited
Loading

This task is about reaping the performance improvements on CPU-MSM by using the h2c implementations of the CPU MSM (which are benched against and improve upon the Zcash implementation, i.e. the status quo)
This was referenced Dec 18, 2023
Merged
Merged
huitseeker added a commit to huitseeker/arecibo that referenced this issue Jan 3, 2024
@huitseeker
chore: Refactors CPU MSM operations using halo2curves library
10da151 
- Expanded the `msm` module within the `provider/util` directory and introduced a new function, `cpu_best_msm`.
- Changed the curves library dependency in `bn256_grumpkin.rs` from `pasta_curves` to `halo2curves`,
- Removed the `msm.rs` file along with two associated functions `cpu_msm_serial` and `cpu_best_msm` used for non-GPU accelerated operations, and all related tests.
- Reorganized the import of `CurveAffine, CurveExt` from the `halo2curves` library in `provider/mod.rs`.

Fixes argumentcomputer#193
@huitseeker huitseeker mentioned this issue Jan 3, 2024
Merged
huitseeker added a commit to huitseeker/arecibo that referenced this issue Jan 3, 2024
@huitseeker
chore: Refactors CPU MSM operations using halo2curves library
547539c 
- Expanded the `msm` module within the `provider/util` directory and introduced a new function, `cpu_best_msm`.
- Changed the curves library dependency in `bn256_grumpkin.rs` from `pasta_curves` to `halo2curves`,
- Removed the `msm.rs` file along with two associated functions `cpu_msm_serial` and `cpu_best_msm` used for non-GPU accelerated operations, and all related tests.
- Reorganized the import of `CurveAffine, CurveExt` from the `halo2curves` library in `provider/mod.rs`.

Fixes argumentcomputer#193
github-merge-queue bot pushed a commit that referenced this issue Jan 4, 2024
@huitseeker
chore: Refactors CPU MSM operations using halo2curves library (#230)
ff30d9b 
- Expanded the `msm` module within the `provider/util` directory and introduced a new function, `cpu_best_msm`.
- Changed the curves library dependency in `bn256_grumpkin.rs` from `pasta_curves` to `halo2curves`,
- Removed the `msm.rs` file along with two associated functions `cpu_msm_serial` and `cpu_best_msm` used for non-GPU accelerated operations, and all related tests.
- Reorganized the import of `CurveAffine, CurveExt` from the `halo2curves` library in `provider/mod.rs`.

Fixes #193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@winston-h-zhang winston-h-zhang

Labels
A-1 Proof Scaling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Refactors CPU MSM operations using halo2curves library huitseeker/arecibo
2 participants
@huitseeker @winston-h-zhang