GPU accelerated Grumpkin MSM #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winston-h-zhang
force-pushed
the
grumpkin-msm
branch
from
77f5c5d
to
cdd223f
Compare
huitseeker
reviewed
Dec 18, 2023
There was a problem hiding this comment.
This is good overall, but we would really benefit from a test that, on the right platforms (x86/aarch64) and under the right feature (cuda), compares the results of cpu_best_msm and grumpkin::{bn256, grumpkin} for a deterministically-seeded random point/scalar vector.
This test should probably have existed in the pasta variant in the first place, and will give us a lot more confidence both in the sppark GPU implementation and in CPU changes required by #193
huitseeker
requested changes
Dec 20, 2023
winston-h-zhang
force-pushed
the
grumpkin-msm
branch
2 times, most recently
from
80d225a
to
36f0d25
Compare
huitseeker
reviewed
Dec 21, 2023
| @@ -47,7 +47,8 @@ rand = "0.8.5" | |||
| ref-cast = "1.0.20" | |||
|
|
|||
| [target.'cfg(any(target_arch = "x86_64", target_arch = "aarch64"))'.dependencies] | |||
| pasta-msm = { git="https://github.com/lurk-lab/pasta-msm", branch="dev", version = "0.1.4" } | |||
| pasta-msm = { git = "https://github.com/lurk-lab/pasta-msm", branch = "dev", version = "0.1.4" } | |||
| grumpkin-msm = { git = "https://github.com/lurk-lab/grumpkin-msm", branch = "dev", features = ["dont-implement-sort"] } | |||
There was a problem hiding this comment.
The following comment would elucidate the feature:
Suggested change
| grumpkin-msm = { git = "https://github.com/lurk-lab/grumpkin-msm", branch = "dev", features = ["dont-implement-sort"] } | |
| # pasta-msm also calls into sppark, which defines the same common sorting code this crate would: the `dont-implement-sort` feature avoid creating conflicting symbols. | |
| grumpkin-msm = { git = "https://github.com/lurk-lab/grumpkin-msm", branch = "dev", features = ["dont-implement-sort"] } |
winston-h-zhang
force-pushed
the
grumpkin-msm
branch
from
36f0d25
to
b30f939
Compare
This was referenced Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #186.
Note:
force-no-sortdoes not disable sorting. It removes redundant sort-related symbols betweenpasta-msmandgrumpkin-msmso the linker is happy.