Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpufrequtils cleanup after PR6507 #6550

Merged
merged 1 commit into from
May 6, 2024

Conversation

SteeManMI
Copy link
Contributor

In PR6507 the use of cpufrequtils was removed and the functionality put into armbian-hardware-optimization This commit removes the remaining now unused installs of the deprecated cpufrequtils package

Changes to be committed:
modified: config/cli/bullseye/main/packages
modified: config/cli/common/main/packages
modified: config/cli/jammy/main/packages

Description

How Has This Been Tested?

  • jammy cli build

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

In PF6507 the use of cpufrequtils was removed and the functionality put into armbian-hardware-optimization
This commit removes the remaining now unused installs of the deprecated cpufrequtils package

 Changes to be committed:
	modified:   config/cli/bullseye/main/packages
	modified:   config/cli/common/main/packages
	modified:   config/cli/jammy/main/packages
@SteeManMI SteeManMI requested a review from igorpecovnik as a code owner May 5, 2024 02:50
@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related like kernel, U-Boot, ... labels May 5, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 05 Milestone: Second quarter release labels May 6, 2024
@SteeManMI SteeManMI merged commit 2b1fae5 into armbian:main May 6, 2024
@SteeManMI SteeManMI deleted the cpufrequtils-cleanup branch May 6, 2024 13:54
@SteeManMI
Copy link
Contributor Author

Still todo is some cleanup in armbian-config which I intend to do soon

@igorpecovnik
Copy link
Member

BTW. Since there is no more of those utils - what about alternative ways of setting speed? Some people would still find this useful.

@SteeManMI
Copy link
Contributor Author

Do you mean something other than armbian-config? With the logic that is now in armbian-hardware-optimization it will read the data from /etc/default/cpufrequtils. So armbian-config can still work to set the data in that file or a user can manually set the values.
Once I get this cleaned up, I want to look at extending the functionality to allow different settings for big cores vs. little cores (rk3399 for example) as what is currently done isn't correct for that environment. I recently saw some work done that was posted int he forums that attempts to do that.

@igorpecovnik
Copy link
Member

I mean in any way, armbian-config way is fine.

at extending the functionality

O.K.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants