Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust quick install guide since we are making a repository on the fly #21

Merged
merged 10 commits into from
Dec 9, 2023

Conversation

igorpecovnik
Copy link
Member

After verifying if we put it into wanted folders and if it works, automation builds upon changes.

After verifying if we put it into wanted folders and if it works, automation builds upon changes.
@igorpecovnik igorpecovnik requested a review from Tearran December 6, 2023 20:56
@Tearran Tearran assigned Tearran and unassigned Tearran Dec 7, 2023
@Tearran Tearran self-requested a review December 7, 2023 05:55
Copy link
Member

@Tearran Tearran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igorpecovnik
Copy link
Member Author

So we want to have README generated via Github actions?

@Tearran
Copy link
Member

Tearran commented Dec 8, 2023

Automating the documentation is part of the project, since brand name issues or and compatibility remain concern within the community. Seemed prudent to use brand as naming convention. $filename --dev uses lib/$filename/* Use case Primarily for later error handling.

Where to direct the documentation, was unclear, so an option or Placeholder was made. Issue #20 cleared so that question

A test to Redirecting all generated to share/doc/$filename/ works locally can delete the whole folder and armbian-configng will make folder share/doc/armbian-config

Naming conventions

For example

ln -s armbian-configng armbian-configng-dev
cp -r  lib/armbian-configng lib/armbian-configng-dev
sudo armbian-configng-dev  -h

will try and use lib/armbian-configng-dev/* if it exist.

sudo armbian-configng-dev --doc will generate share/doc/armbian-configng-dev/*
currently will output path need adjusted from share/brand/documents to share/barand/doc/documents.
This will leave the main README statice.

Alternatively

unsupported-config would look for lib/Unsupported-config

@Tearran
Copy link
Member

Tearran commented Dec 9, 2023

@igorpecovnik

So we want to have README generated via Github actions?

Not really, Was originally intended to have separate readme per Category. In a doc folder. This was the compromised that was made when it was agreed to direct focus away from building and understanding how a *.deb are built.

The doc generators can be easily directed to the share/doc folder now.

@igorpecovnik
Copy link
Member Author

ok. merging this?

@Tearran
Copy link
Member

Tearran commented Dec 9, 2023

Yes. Ran fine on a codespace.

Not sure, about the ci/cd. I only spent few days to get familiar with what a ci/cd pipeline is.

@igorpecovnik
Copy link
Member Author

Not sure, about the ci/cd. I only spent few days to get familiar with what a ci/cd pipeline is.

CI complains about the SheelCheck inconsistency and that has to be taken into account. For future. I also need to add to skip non bash files.

@igorpecovnik igorpecovnik merged commit 6f9b805 into main Dec 9, 2023
1 check failed
@igorpecovnik igorpecovnik deleted the repo-install branch December 9, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants