Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manage_overlayfs: Keep the default value of overlayroot_cfgdisk #372

Merged
merged 1 commit into from
Jan 19, 2025
Merged

manage_overlayfs: Keep the default value of overlayroot_cfgdisk #372

merged 1 commit into from
Jan 19, 2025
+0 −1

Conversation

slowpeek
Copy link
Contributor

"enabled" is not a valid value for the option. Aside for "disabled", here are examples from /etc/overlayroot.conf:

overlayroot_cfgdisk="LABEL=OROOTCFG"
overlayroot_cfgdisk="/dev/vdb"

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@github-actions github-actions bot added the size/small PR with less then 50 lines label Jan 16, 2025
igorpecovnik
igorpecovnik approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@igorpecovnik igorpecovnik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Probably this switch was deprecated within the time.

@igorpecovnik igorpecovnik added 02 Milestone: First quarter release Ready to merge Reviewed, tested and ready for merge labels Jan 19, 2025
@slowpeek @igorpecovnik
manage_overlayfs: Keep the default value of overlayroot_cfgdisk
e2e100f 
"enabled" is not a valid value for the option. Aside for "disabled", here are
examples from /etc/overlayroot.conf:

    overlayroot_cfgdisk="LABEL=OROOTCFG"
    overlayroot_cfgdisk="/dev/vdb"
@igorpecovnik igorpecovnik merged commit 0fadbd2 into armbian:main Jan 19, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

Assignees
No one assigned
Labels
02 Milestone: First quarter release Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slowpeek @igorpecovnik