Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network configuration #60

Closed
wants to merge 7 commits into from
Closed

Conversation

Tearran
Copy link
Member

@Tearran Tearran commented Sep 9, 2024

Added:

  • Configure network interfaces (NetworkManager) Menu sub section.
  • input box to pass user data
  • Has --api (advanced mode) aka "CLI Mode" option to pass arg to change hostname or --cli (simple mode) to use the input box

Issue reference:

#53

Pull request reference:

#55

Implementation Details

Configure network interfaces (NetworkManager)

The existing nmtui was expanded to include other network setting for the TUI

I used for tui "simple mode"

sudo "./bin/armbian-configng" --cli SN07

I used for "cli mode"

sudo "./bin/armbian-configng" --api network_hostname  khadasvim3

justification

This could be a good way to ensure that the basic network configuration is covered
NetworkManager is still compatible with Netplan and included with desktop and Server images.

[[ -n $( grep -m1 'renderer: NetworkManager' /etc/netplan/*.yaml) ]]

@Tearran Tearran linked an issue Sep 9, 2024 that may be closed by this pull request
@Tearran Tearran self-assigned this Sep 9, 2024
"sub": [
{
"id": "SN05",
"description": "Select a Network Connection",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After introducing of Netplan networking config by default, we can drop all direct use of Network Manager. IP, DNS, DHCP ... everything is defined via NetPlan, which passes it to either networkd or network manager. We need to detect it and pass a parameter renderer correctly. This is also backward compatible.

function:
etplan_wrapper "10-dhcp-all-interfaces" "ethernets" "networkd|NetworkManager" "${SELECTED_ADAPTER}" "$IP_ADDRESS""

@Tearran Tearran closed this Sep 9, 2024
@Tearran Tearran deleted the 53-propose-small-design-change branch September 10, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propose small design change
2 participants