Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kafka consumer not destroyed in close #540

Open
wants to merge 1 commit into
base: 6.x
Choose a base branch
from

Conversation

ikeberlein
Copy link
Contributor

@ikeberlein ikeberlein commented Jun 6, 2023

Not destroying underlying kafka consumer in close() method leads to unclean librdkafka shutdown and very often to segfaults.

@ikeberlein ikeberlein closed this Jun 6, 2023
@ikeberlein ikeberlein reopened this Jun 6, 2023
@ikeberlein ikeberlein marked this pull request as ready for review June 6, 2023 13:42
@ikeberlein ikeberlein closed this Jun 6, 2023
@ikeberlein ikeberlein reopened this Jun 6, 2023
@ikeberlein ikeberlein closed this Jun 6, 2023
@ikeberlein ikeberlein reopened this Jun 6, 2023
@ikeberlein ikeberlein closed this Jun 6, 2023
@ikeberlein ikeberlein reopened this Jun 6, 2023
@ikeberlein ikeberlein force-pushed the FixConsumerNotDestroyedOnClose branch from 73dc305 to 24e0e9c Compare January 12, 2024 09:27
@arnaud-lb
Copy link
Owner

Normally the rk handle is destroyed when the KafkaConsumer object itself is destroyed, so I don't think we need to close it explicitly here. However maybe we don't destroy various resources in the right order when the rk is closed later?

Do you have a reproducer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants