Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary text 'CLICKING 2' #765

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

naeem-gitonga
Copy link

Description

remove logging text

Motivation and Context

Checklist

[ ] I have not included any built dist files (us maintainers do that prior to a new release)
[ ] I have added tests covering my changes
[ ] All new and existing tests pass
[ ] My changes required the documentation to be updated
  [ ] I have updated the documentation accordingly
  [ ] I have updated the TypeScript 1.8 type definitions accordingly
  [ ] I have updated the TypeScript 2.0+ type definitions accordingly

**not sure if you guys know but there are 24 test failing locally prior to making any changes on your master branch. just running a build on your project creates too many other changes to the files in the dist dir. I simply removed the text in the log however I believe a new build is actually needed. If this isn't merged I at least hope that you guys run a new build and push those files **
Screen Shot 2020-12-20 at 4 21 15 PM

@naeem-gitonga naeem-gitonga changed the title chore: run build command/ remove unnecessary logging 'CLICKING 2' chore: remove unnecessary text 'CLICKING 2' Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant