Use TMPDIR environment variable for temporary file path in createAndRunScript #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @camlyall, this looks good. I wonder if we could improve that function a bit and since it lacks test coverage at the moment add a test for it. Maybe we could use pytest monkeypatch.setenv and tmp_path to test the TMPDIR case.
|
@camlyall Out of curiosity, are you planning to address this in the Storage Service which I think has a similar problem when compressing packages? |
replaceafill
added
AMAUAT
replaceafill
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes use of hardcoded temp directory.
This fixes issue archivematica/Issues#1425
Reviewed in AM1.14
Users facing the issue 7z when mounting /tmp directory with noexec can set the environment variable
TMPDIR=/path/to/dirin /etc/default/archivematica-mcp-client