Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App recognition for music players who identify as com.android.music #209

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Alia5
Copy link

@Alia5 Alia5 commented Nov 28, 2015

  • As in Issue #207 check for specific Intent-Extra when receiving MetaData from generic audio player "com.android.music.XXX"

- As in Issue artem-zinnatullin#207 check for specific Intent-Extra when receiving MetaData from generic audio player "com.android.music.XXX"
@@ -4,15 +4,16 @@ repositories {
maven() {
url 'http://jcenter.bintray.com'
}
maven { url "https://jitpack.io" }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need jitpack?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He couldn't find this library...
https://github.com/afollestad/material-dialogs
Just added the correct repo according to the projects git

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, can you please change quotes from double " to single '?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@artem-zinnatullin
Copy link
Owner

Okay, please fix the build and I'll merge this :)

@Alia5
Copy link
Author

Alia5 commented Nov 29, 2015

Dunno whats exactly wrong here... For me, locally, it builds just fine.

@artem-zinnatullin
Copy link
Owner

Okay, I see, can you please add

- platform-tools
- tools

to the .travis.yml android->components?

@Alia5
Copy link
Author

Alia5 commented Nov 30, 2015

I have no clue about travis, so sorry for the hassle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants