Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arbitrary code execution vulnerability #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lennartkoebe
Copy link

Internally unix-print uses exec calls which are very easy to exploit.

e.g.

const file = "assets/file.pdf";
const userProvidedPrinterName = "&& user_provided_evil_command";
print(file, userProvidedPrinterName);

This was fixed by using execFile instead.

see https://nodejs.org/api/child_process.html#child_processexecfilefile-args-options-callback

`exec` is prone to command injection.
It was replaced by `execFile` which is more secure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant