feat: add Spring Boot service #48
Conversation
genryxy
requested review from
a team and
olenagerasimova
and removed request for
a team
| import org.springframework.web.multipart.MultipartFile; | ||
|
|
||
| @RestController | ||
| public class FileController { |
There was a problem hiding this comment.
what will happen if runtime exception is thrown while saving/getting file? 500 status will be returned?
|
|
||
| @PostMapping("upload") | ||
| @ResponseStatus(HttpStatus.CREATED) | ||
| public ResponseEntity<String> uploadFile(@RequestParam("file") MultipartFile file) { |
There was a problem hiding this comment.
why multipart? in our files adapter files are uploaded not as multipart body, file binary body is the body of the request...
| import org.springframework.web.multipart.MultipartFile; | ||
|
|
||
| @RestController | ||
| public class FileController { |
There was a problem hiding this comment.
also, I'd suggest to add
- unit tests for the
FileServiceand controller - qulice to check codestyle
There was a problem hiding this comment.
Is it necessary to add qulice check style if the main purpose of this application is only benchmark?
There was a problem hiding this comment.
I'd say yes, it's even more important for benchmarks to be properly written and perfectly readable as in the case of mistake the results can be not valid... It's my opinion, however, ask Kirill if you have doubts.
|
@olenagerasimova thanks, all corrected |
|
@g4s8 please check/merge |
Part of #47
Create a simple Spring Boot service for uploading and downloading files. This service will be used lased to compare performance with Artipie realization.