feat: add Artipie server #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genryxy
requested review from
a team and
olenagerasimova
and removed request for
a team
| final Iterable<Map.Entry<String, String>> headers, | ||
| final Publisher<ByteBuffer> body | ||
| ) { | ||
| Response res; |
There was a problem hiding this comment.
I'm not sure that relevant, but I thunk it would be better to implement this slice in async way, using AsyncResponce and CompletableFuture.supplyAsync() or runAsync
| Files.walk(this.toclean) | ||
| .sorted(Comparator.reverseOrder()) | ||
| .map(Path::toFile) | ||
| .forEach(File::delete); |
There was a problem hiding this comment.
also, will it not fail if there are internal directories? Maybe, it would make sense to add commons.io dependency and FileUtils.detele
|
@olenagerasimova thanks, corrected |
genryxy
force-pushed
the
47-artipie-file
branch
from
449ed48 to
f92785a
Compare
|
@g4s8 could you please check/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #47
Create a simple Artipie server for uploading and downloading binary data. This service will be used later to compare performance with Spring realization