ci(workflows): use uv to install dependencies in main workflow run #6
Conversation
|
Warning Rate limit exceeded@arunanshub has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 5 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes enhance the CI workflow in Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/ci.yml (2 hunks)
Additional context used
actionlint
.github/workflows/ci.yml
70-70: shellcheck reported issue in this script: SC2028:info:1:6: echo may not expand escape sequences. Use printf
(shellcheck)
70-70: shellcheck reported issue in this script: SC2086:info:1:39: Double quote to prevent globbing and word splitting
(shellcheck)
Additional comments not posted (2)
.github/workflows/ci.yml (2)
65-67: Approved: Installation of theuvinstaller usingpipx.This is a standard practice for installing Python tools in isolated environments, which is suitable for CI workflows to avoid conflicts.
86-89: Approved: Updated installation process for Python dependencies usinguv.The shift from
pdm installto usinguv pipwith arequirements.txtfile is a structured approach that enhances reproducibility and performance.
.github/workflows/ci.yml
Outdated
| - name: Get uv cache directory | ||
| id: uv-cache | ||
| run: | | ||
| echo "cache-dir=$(uv cache dir)\n" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Setup uv Cache | ||
| uses: actions/cache@v4 | ||
| with: | ||
| key: uv-${{ runner.os }}-${{ matrix.python-version }}-pdm | ||
| path: ${{ steps.uv-cache.outputs.cache-dir }} |
There was a problem hiding this comment.
Fix shell script issues and approve caching setup.
The caching mechanism is correctly set up using actions/cache. However, the script has issues that need addressing:
- Use
printfinstead ofechoto ensure escape sequences are handled correctly. - Ensure variables are double-quoted to prevent globbing and word splitting.
Apply this diff to fix the script issues:
- echo "cache-dir=$(uv cache dir)\n" >> $GITHUB_OUTPUT
+ printf "cache-dir=%s\n" "$(uv cache dir)" >> $GITHUB_OUTPUTCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Get uv cache directory | |
| id: uv-cache | |
| run: | | |
| echo "cache-dir=$(uv cache dir)\n" >> $GITHUB_OUTPUT | |
| - name: Setup uv Cache | |
| uses: actions/cache@v4 | |
| with: | |
| key: uv-${{ runner.os }}-${{ matrix.python-version }}-pdm | |
| path: ${{ steps.uv-cache.outputs.cache-dir }} | |
| - name: Get uv cache directory | |
| id: uv-cache | |
| run: | | |
| printf "cache-dir=%s\n" "$(uv cache dir)" >> $GITHUB_OUTPUT | |
| - name: Setup uv Cache | |
| uses: actions/cache@v4 | |
| with: | |
| key: uv-${{ runner.os }}-${{ matrix.python-version }}-pdm | |
| path: ${{ steps.uv-cache.outputs.cache-dir }} |
Tools
actionlint
70-70: shellcheck reported issue in this script: SC2028:info:1:6: echo may not expand escape sequences. Use printf
(shellcheck)
70-70: shellcheck reported issue in this script: SC2086:info:1:39: Double quote to prevent globbing and word splitting
(shellcheck)
Pull Request Test Coverage Report for Build 10544579924Details
💛 - Coveralls |
Summary by CodeRabbit
New Features
Improvements