Skip to content

Commit

Permalink
making workflow and pom changes to test only dev test
Browse files Browse the repository at this point in the history
Signed-off-by: Arun Venmany <[email protected]>
  • Loading branch information
arunvenmany-ibm committed Jan 15, 2025
1 parent 7259809 commit bb1ec32
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
run: ./mvnw -V verify --batch-mode --no-transfer-progress --errors -DtrimStackTrace=false -Ponline-its -D"invoker.streamLogsOnFailures"=true -D"invoker.test"="*setup*,*springboot-3-*,*compile-jsp-source-17-*" -Druntime=${{ matrix.RUNTIME }} -DruntimeVersion="${{ matrix.RUNTIME_VERSION }}"
# Run tests
- name: Run tests
run: ./mvnw -V verify --batch-mode --no-transfer-progress --errors -DtrimStackTrace=false -Ponline-its -D"invoker.streamLogsOnFailures"=true -Druntime=${{ matrix.RUNTIME }} -DruntimeVersion="${{ matrix.RUNTIME_VERSION }}"
run: ./mvnw -V verify --batch-mode --no-transfer-progress --errors -DtrimStackTrace=false -Ponline-its -D"invoker.streamLogsOnFailures"=true -D"invoker.test"="*dev-it*" -Druntime=${{ matrix.RUNTIME }} -DruntimeVersion="${{ matrix.RUNTIME_VERSION }}"

# WINDOWS BUILD
build-windows:
Expand Down
4 changes: 3 additions & 1 deletion liberty-maven-plugin/src/it/dev-it/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@
<argLine>-enableassertions</argLine>
<workingDirectory>${project.build.directory}</workingDirectory>
<includes>
<include>**/*Test.java</include>
<include>**/*DevRecompileWithCustomExecutionIdTest.java</include>
<include>**/*DevRecompileWithDefaultExecutionIdTest.java</include>
<include>**/*DevTest.java</include>
</includes>
<systemPropertyVariables>
<mavenPluginVersion>@pom.version@</mavenPluginVersion>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,19 @@ public class DevRecompileWithCustomExecutionIdTest extends BaseDevTest {

@BeforeClass
public static void setUpBeforeClass() throws Exception {
setUpBeforeClass(null, "../resources/basic-dev-project-with-execution-id", false, false, null, null);
startProcess(null, false, "mvn compile liberty:", false);
setUpBeforeClass(null, "../resources/basic-dev-project-with-execution-id", true, false, null, null);
startProcess(null, true, "mvn compile liberty:", true);
}

@AfterClass
public static void cleanUpAfterClass() throws Exception {
BaseDevTest.cleanUpAfterClass(false, false);
BaseDevTest.cleanUpAfterClass(true, true);
}

@Test
public void validateRunExecutionNotSkipped() throws Exception {
//java-compile is the custom execution id
assertTrue(verifyLogMessageExists("Running maven-compiler-plugin:compile#java-compile", 120000));
assertTrue(verifyLogMessageExists("Nothing to compile - all classes are up to date.", 120000));
assertTrue(getLogTail(), verifyLogMessageExists("Running maven-compiler-plugin:compile#java-compile", 120000));
assertTrue(getLogTail(), verifyLogMessageExists("Nothing to compile - all classes are up to date.", 120000));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -36,20 +36,20 @@ public class DevRecompileWithDefaultExecutionIdTest extends BaseDevTest {

@BeforeClass
public static void setUpBeforeClass() throws Exception {
setUpBeforeClass(null, "../resources/basic-dev-project-with-default-execution-id", false, false, null, null);
startProcess(null, false, "mvn compile liberty:", false);
setUpBeforeClass(null, "../resources/basic-dev-project-with-default-execution-id", true, false, null, null);
startProcess(null, true, "mvn compile liberty:", true);
}

@AfterClass
public static void cleanUpAfterClass() throws Exception {
BaseDevTest.cleanUpAfterClass(false, false);
BaseDevTest.cleanUpAfterClass(true, true);
}

@Test
public void validateRunExecutionNotSkipped() throws Exception {
assertTrue(verifyLogMessageExists("Nothing to compile - all classes are up to date.", 120000));
// Check that the correct execution id is picked up
// in this case, we are not passing any execution id in pom.xml, hence default execution id will be taken up
assertTrue(verifyLogMessageExists("Running maven-compiler-plugin:compile#default-compile", 120000));
assertTrue(getLogTail(), verifyLogMessageExists("Running maven-compiler-plugin:compile#default-compile", 120000));
assertTrue(getLogTail(), verifyLogMessageExists("Nothing to compile - all classes are up to date.", 120000));
}
}

0 comments on commit bb1ec32

Please sign in to comment.