Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA workflow update #7699

Merged
merged 7 commits into from
Jul 21, 2024
Merged

GHA workflow update #7699

merged 7 commits into from
Jul 21, 2024

Conversation

arvidn
Copy link
Owner

@arvidn arvidn commented Jul 1, 2024

No description provided.

@arvidn arvidn force-pushed the gha-workflow-update branch from 9e46fcc to dcc21bc Compare July 1, 2024 12:23
@xavier2k6
Copy link
Contributor

xavier2k6 commented Jul 20, 2024

@arvidn for pre-commit failure, quote the actual python version -> python-version: "3.10" & that should resolve failure.

CodeQL - Perhaps you could also use the CMake version that comes pre-installed on runner image rather than downloading/installing a specified version.

cibuildwheel/cirrus - update action to 2.19.2

@arvidn arvidn force-pushed the gha-workflow-update branch from dcc21bc to c02de29 Compare July 20, 2024 19:33
@arvidn arvidn marked this pull request as ready for review July 20, 2024 19:33
@arvidn arvidn force-pushed the gha-workflow-update branch from c02de29 to 2b9c865 Compare July 20, 2024 20:22
@arvidn
Copy link
Owner Author

arvidn commented Jul 20, 2024

the cibuildwheel is targeting an older MacOS than what the image supports

@xavier2k6
Copy link
Contributor

the cibuildwheel is targeting an older MacOS than what the image supports

You've set it to 10.9 below:

MACOSX_DEPLOYMENT_TARGET = "10.9" # required for full C++11 support

I've been looking in to this via the macOS arm PR & newer actions which require different targets for x64/arm......I believe if the MACOSX_DEPLOYMENT_TARGET was not set by the user it is automatically set to the associated requirement through the cibuildwheel action.

@xavier2k6
Copy link
Contributor

xavier2k6 commented Jul 20, 2024

What I meant was to remove below line completely & let the cibuildwheel action automatically set the correct "minimum target"

MACOSX_DEPLOYMENT_TARGET = "10.9" # required for full C++11 support

Look at Line 294 onwards in relation to MACOSX_DEPLOYMENT_TARGET
https://github.com/pypa/cibuildwheel/blob/main/cibuildwheel/macos.py#L294

@arvidn arvidn force-pushed the gha-workflow-update branch from 422a2ba to 0e8705c Compare July 21, 2024 07:53
@xavier2k6
Copy link
Contributor

I wondering about current failure ......is it to do with OpenSSL being installed from brew rather than being installed from source?

@arvidn arvidn force-pushed the gha-workflow-update branch from f62982b to 381008e Compare July 21, 2024 15:32
@arvidn arvidn force-pushed the gha-workflow-update branch from 381008e to 1ee9996 Compare July 21, 2024 16:25
@arvidn arvidn merged commit d3eef89 into RC_2_0 Jul 21, 2024
48 of 49 checks passed
@arvidn arvidn deleted the gha-workflow-update branch July 21, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants