Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Improvements for Separation Plot #2272

Closed
wants to merge 1 commit into from

Conversation

arshm06
Copy link
Contributor

@arshm06 arshm06 commented Jul 30, 2023

Description

Visually Improved the Separation Plot. (Issue number: #2114)

Pushed the expected events marker down. Moved the legend out of the plot. Remove the axes edgeline.

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2272.org.readthedocs.build/en/2272/

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #2272 (6461dd1) into main (24c260a) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2272   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files         122      122           
  Lines       12459    12459           
=======================================
  Hits        10952    10952           
  Misses       1507     1507           
Files Changed Coverage Δ
arviz/plots/backends/matplotlib/lmplot.py 98.75% <100.00%> (ø)

@OriolAbril
Copy link
Member

Thanks again for the PR. There might have been an issue with the commits and/or branches. The PR looks identical to #2271, modifying plot_lm instead of plot_separation

@OriolAbril
Copy link
Member

Closing for now, will reopen if updated with different changes

@OriolAbril OriolAbril closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants