Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_ppc related fixes #2283

Merged
merged 3 commits into from
Oct 30, 2023
Merged

plot_ppc related fixes #2283

merged 3 commits into from
Oct 30, 2023

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Oct 13, 2023

Description

Modify plot_ppc default labeling and several plot_ppc fixes, mainly working properly when
chain and draw aren't the first dimensions positionally

Checklist

  • Follows official PR format
  • Includes new or updated tests to prevent regression on the fix
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2283.org.readthedocs.build/en/2283/

* Multiple docstring fixes and improvements
* Avoid adding empty legends, don't add anything instead
* Ensure plot behaves correctly even if chain and draw aren't the first
  dimensions positionally
  - Add test to check behaviour and avoid regression
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #2283 (1b06391) into main (4557004) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2283      +/-   ##
==========================================
+ Coverage   86.71%   86.78%   +0.07%     
==========================================
  Files         122      122              
  Lines       12459    12460       +1     
==========================================
+ Hits        10804    10814      +10     
+ Misses       1655     1646       -9     
Files Coverage Δ
arviz/labels.py 93.67% <100.00%> (+0.16%) ⬆️
arviz/plots/backends/matplotlib/ppcplot.py 97.63% <ø> (-0.02%) ⬇️
arviz/plots/ppcplot.py 89.33% <ø> (ø)

... and 2 files with indirect coverage changes

@aloctavodia aloctavodia merged commit c2d968f into arviz-devs:main Oct 30, 2023
11 checks passed
@OriolAbril OriolAbril deleted the plot_ppc branch October 30, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants