Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CmdstanPy converter #2287

Merged
merged 4 commits into from
Nov 12, 2023
Merged

Update CmdstanPy converter #2287

merged 4 commits into from
Nov 12, 2023

Conversation

ahartikainen
Copy link
Contributor

@ahartikainen ahartikainen commented Nov 8, 2023

Description

Checklist

  • Follows official PR format
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2287.org.readthedocs.build/en/2287/

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2287 (bc153df) into main (c2d968f) will increase coverage by 0.10%.
The diff coverage is 32.12%.

@@            Coverage Diff             @@
##             main    #2287      +/-   ##
==========================================
+ Coverage   86.78%   86.89%   +0.10%     
==========================================
  Files         122      122              
  Lines       12460    12628     +168     
==========================================
+ Hits        10814    10973     +159     
- Misses       1646     1655       +9     
Files Coverage Δ
arviz/data/io_cmdstanpy.py 43.27% <32.12%> (+27.39%) ⬆️

@ahartikainen
Copy link
Contributor Author

@OriolAbril this is quite minimal change and still works with older models.
For test changes, we can probably create a new PR?

@ahartikainen
Copy link
Contributor Author

I will quickly check cases for 1.1.0 so it will work too.

@ahartikainen
Copy link
Contributor Author

ahartikainen commented Nov 8, 2023

So now it should support

<0.9.67
<1.0.0
<1.20
1.2.0+

@ahartikainen ahartikainen merged commit 643d4fb into main Nov 12, 2023
10 of 11 checks passed
@ahartikainen ahartikainen deleted the bugfix/cmdstanpy_reader branch November 12, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant