Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid bins='auto' on jitted histogram #2289

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Nov 14, 2023

Description

fixes #2282

Checklist

  • Does the PR follow official PR format?
  • Does the PR include new or updated tests to prevent issue recurrence (using pytest fixture pattern)?
  • Is the code style correct (follows pylint and black guidelines)?
  • Is the fix listed in the Maintenance and fixes section of the changelog?

📚 Documentation preview 📚: https://arviz--2289.org.readthedocs.build/en/2289/

Copy link
Contributor

@ahartikainen ahartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Is this similar we do with bokeh?

@OriolAbril
Copy link
Member Author

Is this similar we do with bokeh?

bokeh already did this instead of using "auto"

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb88f3a) 86.89% compared to head (6c3c5e6) 86.89%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2289      +/-   ##
==========================================
- Coverage   86.89%   86.89%   -0.01%     
==========================================
  Files         122      122              
  Lines       12628    12640      +12     
==========================================
+ Hits        10973    10983      +10     
- Misses       1655     1657       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OriolAbril OriolAbril merged commit dc2f902 into arviz-devs:main Nov 14, 2023
10 checks passed
@OriolAbril OriolAbril deleted the hist_auto branch November 14, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests test_plot_ppc_discrete... fail with kde.
2 participants