Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update active tests #2290

Merged
merged 11 commits into from
Nov 15, 2023
Merged

Update active tests #2290

merged 11 commits into from
Nov 15, 2023

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Nov 14, 2023

Dropping beanmachine we also are able to use latest black, instead
of the over a year old version beanmachine pulls as runtime
dependency.

I also want to fix the readthedocs build in this PR.

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2290.org.readthedocs.build/en/2290/

Dropping beanmachine we also are able to use latest black, instead
of the over a year old version beanmachine pulls as _runtime_
dependency.
@OriolAbril OriolAbril marked this pull request as ready for review November 14, 2023 18:34
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (eb88f3a) 86.89% compared to head (cb21419) 86.70%.
Report is 2 commits behind head on main.

Files Patch % Lines
arviz/data/io_pyjags.py 0.00% 2 Missing ⚠️
arviz/data/io_beanmachine.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2290      +/-   ##
==========================================
- Coverage   86.89%   86.70%   -0.20%     
==========================================
  Files         122      122              
  Lines       12628    12640      +12     
==========================================
- Hits        10973    10959      -14     
- Misses       1655     1681      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ahartikainen ahartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Added one comment

requirements-dev.txt Outdated Show resolved Hide resolved
@OriolAbril OriolAbril merged commit 595fd7f into arviz-devs:main Nov 15, 2023
9 of 11 checks passed
@OriolAbril OriolAbril deleted the infra branch November 15, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants