-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle multimodal cases in maxent #635
base: main
Are you sure you want to change the base?
Conversation
Some things to ask here:
What do you suggest @aloctavodia ? |
I am adding a mode to other Python files, and I will make a pull request. is that fine @rohanbabbar04 |
Sure, can you comment on #604 which ones are you working on so that we don't pick the same ones? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
==========================================
- Coverage 82.23% 74.26% -7.97%
==========================================
Files 101 105 +4
Lines 8020 8711 +691
==========================================
- Hits 6595 6469 -126
- Misses 1425 2242 +817 ☔ View full report in Codecov by Sentry. |
Sure, you have already implemented Rice and Binomial, so I will drop this since I have already implemented it in my local setup. |
Not sure, but probably better to return a tuple if more than one mode. And as a first approach allow to fix a single mode in maxent, but handle de case that the mode method could return a tuple |
Description
Checklist