Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MagicFlare refactors #292

Open
wants to merge 122 commits into
base: master
Choose a base branch
from
Open

MagicFlare refactors #292

Changes from 11 commits
Commits
Show all changes
122 commits
Select commit Hold shift + click to select a range
dcf58db
MagicFlare: Encapsulate magic flare array in a container
bsxf-47 Sep 10, 2023
d3fc2c8
MagicFlare: Turn MagicFlare into its own class
bsxf-47 Sep 10, 2023
4b6d53a
MagicFlare: Extract member function
bsxf-47 Sep 10, 2023
5c8e212
MagicFlare: Extract member variable
bsxf-47 Sep 10, 2023
579512e
MagicFlare: Move declarations and definitions
bsxf-47 Sep 10, 2023
0eccf1a
MagicFlare: Extract member function
bsxf-47 Sep 10, 2023
8f7adc5
MagicFlares: Extract member function
bsxf-47 Sep 10, 2023
ee87ccc
MagicFlare: Extract member variable
bsxf-47 Sep 10, 2023
24798dc
MagicFlare: Extract member function
bsxf-47 Sep 10, 2023
c9e2852
MagicFlare: Extract member function
bsxf-47 Sep 10, 2023
0311a2f
MagicFlare: Extract function
bsxf-47 Sep 10, 2023
454a82b
MagicFlare: Extract member variable
bsxf-47 Sep 10, 2023
3bcb375
MagicFlare: Extract member variable
bsxf-47 Sep 10, 2023
977ae05
MagicFlare: Extract member function
bsxf-47 Sep 10, 2023
8c0b908
MagicFlare: Rename member variable
bsxf-47 Sep 10, 2023
ec30783
MagicFlare: Initialize member variables
bsxf-47 Sep 10, 2023
eadeab4
MagicFlare: Extract member function
bsxf-47 Sep 10, 2023
22e0192
MagicFlare: Extract member function
bsxf-47 Sep 12, 2023
bbb410c
MagicFlare: Start index at zero
bsxf-47 Sep 12, 2023
7e14259
MagicFlare: Use correct array size
bsxf-47 Sep 12, 2023
c6811ad
MagicFlare: Rename member variable
bsxf-47 Sep 12, 2023
e5c8e10
MagicFlare: Rename variable
bsxf-47 Sep 13, 2023
9c62384
MagicFlare: Rewrite to switch
bsxf-47 Sep 13, 2023
b512d7b
MagicFlare: Extract member function
bsxf-47 Sep 13, 2023
4f834b9
MagicFlare: Remove nested for loop
bsxf-47 Sep 13, 2023
07baa88
MagicFlare: Rename member variable
bsxf-47 Sep 13, 2023
a4758b8
MagicFlare: Change type to bool
bsxf-47 Sep 13, 2023
e7a647e
MagicFlare: Rename variable
bsxf-47 Sep 14, 2023
3914787
MagicFlare: Include texture loading in init()
bsxf-47 Sep 14, 2023
7694002
MagicFlare: Extract member function
bsxf-47 Sep 14, 2023
6cfdba4
MagicFlare: Rename member variable
bsxf-47 Sep 14, 2023
5e51e8a
MagicFlare: Rename member variable
bsxf-47 Sep 14, 2023
34159b2
MagicFlare: Don't use object
bsxf-47 Sep 14, 2023
0f04799
MagicFlare: Extract member function
bsxf-47 Sep 14, 2023
6cf2952
MagicFlare: Rename variable
bsxf-47 Sep 14, 2023
c4a508a
MagicFlare: Extract member function
bsxf-47 Sep 14, 2023
b02d768
MagicFlare: Rename parameter
bsxf-47 Sep 17, 2023
3201f23
MagicFlare: Rename parameter
bsxf-47 Sep 17, 2023
4c5a97f
MagicFlare: Rename variable
bsxf-47 Sep 17, 2023
da458ca
MagicFlare: Rename variable
bsxf-47 Sep 17, 2023
c3ae0e9
MagicFlare: Rename variable
bsxf-47 Sep 17, 2023
011bdcd
MagicFlare: Rename variable
bsxf-47 Sep 17, 2023
c78e461
MagicFlare: Rename variable
bsxf-47 Sep 17, 2023
bb105e2
MagicFlare: Change parameter type
bsxf-47 Sep 17, 2023
e8e8e2b
MagicFlare: Rename parameter
bsxf-47 Sep 17, 2023
b52752d
MagicFlare: Rewrite decimal as fraction
bsxf-47 Sep 17, 2023
f198476
MagicFlare: Rewrite decimal as fraction
bsxf-47 Sep 17, 2023
9e6e1d6
MagicFlare: Rename member function
bsxf-47 Sep 17, 2023
7770695
MagicFlare: Rename function
bsxf-47 Sep 17, 2023
df81970
MagicFlare: Rename member function
bsxf-47 Sep 17, 2023
9e101f0
MagicFlare: Use member variable
bsxf-47 Sep 19, 2023
ad1e260
MagicFlare: Use member variable
bsxf-47 Sep 19, 2023
a185213
MagicFlare: Use member variable
bsxf-47 Sep 19, 2023
21bfa24
MagicFlare: Use member variable
bsxf-47 Sep 19, 2023
2746bf9
MagicFlare: Use member variable
bsxf-47 Sep 19, 2023
42050a9
MagicFlare: Use member variable
bsxf-47 Sep 19, 2023
157a967
MagicFlare: Use member variable directly
bsxf-47 Sep 19, 2023
d47a8c3
MagicFlare: Use member variable
bsxf-47 Sep 19, 2023
da41d18
MagicFlare: Rename member variable
bsxf-47 Sep 19, 2023
f5c315c
MagicFlare: Extract member function
bsxf-47 Sep 19, 2023
b000752
MagicFlare: Rename member variable
bsxf-47 Sep 20, 2023
2d05c94
MagicFlare: Rename member variable
bsxf-47 Sep 20, 2023
1acded0
MagicFlare: Use member variable instead of local one
bsxf-47 Sep 21, 2023
932fcb1
MagicFlare: Extract member function
bsxf-47 Sep 21, 2023
6c32b89
MagicFlare: Rename member variable
bsxf-47 Sep 21, 2023
f1fb9b6
MagicFlare: Use member variable instead of a local one
bsxf-47 Sep 21, 2023
6ff6653
MagicFlare: Move code to member function
bsxf-47 Sep 21, 2023
555a648
MagicFlare: Invert logic
bsxf-47 Sep 21, 2023
3ffaae0
MagicFlare: Remove unnecessary check
bsxf-47 Sep 21, 2023
fddccb8
MagicFlare: Change type to bool
bsxf-47 Sep 21, 2023
ea34562
MagicFlare: Rename member variable
bsxf-47 Sep 21, 2023
854b5e4
MagicFlare: Rename class
bsxf-47 Sep 23, 2023
ff6edf6
MagicFlare: Define a container class for flares
bsxf-47 Sep 24, 2023
f899d92
MagicFlare: Move overloaded operator to container class
bsxf-47 Sep 24, 2023
32a2fe5
MagicFlare: Use container class
bsxf-47 Sep 24, 2023
ffafb01
MagicFlare: Use member function
bsxf-47 Sep 24, 2023
f11c8d7
MagicFlare: Move definition
bsxf-47 Sep 24, 2023
db16861
MagicFlare: Move member function to container class
bsxf-47 Sep 24, 2023
e402a12
MagicFlare: Move member function to container class
bsxf-47 Sep 24, 2023
7353ad4
MagicFlare: Use member function
bsxf-47 Sep 24, 2023
a7a5de2
MagicFlare: Make member function private
bsxf-47 Sep 24, 2023
ebfad35
MagicFlare: Use for loop range
bsxf-47 Sep 24, 2023
9b0775d
MagicFlare: Use for loop range
bsxf-47 Sep 24, 2023
ba5511d
MagicFlare: Use for loop range
bsxf-47 Sep 24, 2023
3d94c9c
MagicFlare: Use for loop range
bsxf-47 Sep 24, 2023
923f05c
MagicFlare: Use for loop range
bsxf-47 Sep 24, 2023
d866cac
MagicFlare: Remove obsolete operator
bsxf-47 Sep 24, 2023
77a643a
MagicFlare: Remove unused member variable
bsxf-47 Sep 24, 2023
2366070
MagicFlare: Remove now unused member variable
bsxf-47 Sep 26, 2023
49fb792
MagicFlare: Make member variable private
bsxf-47 Sep 26, 2023
3aeb707
MagicFlare: Remove dead code
bsxf-47 Sep 28, 2023
69245b0
MagicFlare: Clear IO information on clear()
bsxf-47 Sep 30, 2023
2d24b2a
MagicFlare: Extract member function
bsxf-47 Sep 30, 2023
3c6fd75
MegicFlare: Extract member function
bsxf-47 Sep 30, 2023
ab47139
MagicFlare: Clear type on clear()
bsxf-47 Oct 1, 2023
27a28e9
MagicFlare: Use member function
bsxf-47 Oct 1, 2023
401ae2c
MagicFlare: Move texture container logic
bsxf-47 Oct 1, 2023
9228319
MagicFlare: Move definition
bsxf-47 Oct 1, 2023
009c0a5
MagicFlare: Move definition
bsxf-47 Oct 1, 2023
d12e1e8
MagicFlare: Remove unneeded parameter
bsxf-47 Oct 1, 2023
c3d1389
MagicFlare: Rename member function
bsxf-47 Oct 1, 2023
95a7d7a
MagicFlare: Rename member variable
bsxf-47 Oct 1, 2023
33ab1e2
MagicFlare: Use member variable
bsxf-47 Oct 1, 2023
ea54c2f
MagicFlare: Remove extraneous parameter
bsxf-47 Oct 1, 2023
13c30a8
MagicFlare: Remove extraneous parameter
bsxf-47 Oct 1, 2023
8adccd3
MagicFlare: Use member variable
bsxf-47 Oct 1, 2023
ed26163
MagicFlare: Remove extraneous parameter
bsxf-47 Oct 1, 2023
4625215
MagicFlare: Use wrapper function
bsxf-47 Oct 1, 2023
c6202e2
MagicFlare: Use wrapper function
bsxf-47 Oct 1, 2023
12c5ed3
MagicFlare: Use wrapper function
bsxf-47 Oct 1, 2023
43c9f6e
MagicFlare: Use Vec2f
bsxf-47 Oct 1, 2023
1712bf2
MagicFlare: Use Vec2f
bsxf-47 Oct 1, 2023
c13c337
MagicFlare: Use local variables
bsxf-47 Oct 1, 2023
b90e79b
MagicFlare: Use local variables
bsxf-47 Oct 1, 2023
0284750
MagicFlare: Remove redundant check
bsxf-47 Oct 1, 2023
70f175e
MagicFlare: Rewrite function to remove duplicate code
bsxf-47 Oct 3, 2023
bc53268
MagicFlare: Remove helper function
bsxf-47 Oct 3, 2023
96ef76f
MagicFlare: Extract member function
bsxf-47 Oct 3, 2023
903c15b
MagicFlare: Pass positions as const references
bsxf-47 Oct 3, 2023
de938f5
MagicFlare: Remove redundant member variable
bsxf-47 Oct 3, 2023
80d6021
MagicFlare: Fix code style
bsxf-47 Oct 5, 2023
8811a16
MagicFlare: Mark constructor as explicit
bsxf-47 Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading