Skip to content

Commit

Permalink
excluding protobuf group as shadowJar relocation did not work (feathr…
Browse files Browse the repository at this point in the history
…-ai#1191)

Co-authored-by: Anirudh Agarwal <[email protected]>
  • Loading branch information
anirudhagar13 and Anirudh Agarwal authored Jun 15, 2023
1 parent 5a52089 commit 52658eb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
9 changes: 1 addition & 8 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ plugins {
// See https://issues.sonatype.org/browse/OSSRH-86507 for more details.
id "com.vanniktech.maven.publish" version "0.22.0"
id 'signing'
id 'com.github.johnrengelman.shadow' version '5.0.0'
}

repositories {
Expand Down Expand Up @@ -53,6 +52,7 @@ jar {
// Explicitly exclude com/linkedin/data and org/apache/hadoop files from the final jar. They can cause issues in other downstream applications.
exclude 'com/linkedin/data/**'
exclude 'org/apache/hadoop/**'
exclude 'com/google/**'
zip64 = true
}

Expand Down Expand Up @@ -188,10 +188,3 @@ allprojects {
}
}
}

apply plugin: 'com.github.johnrengelman.shadow'

shadowJar {
configurations = [project.configurations.shadow]
relocate "com.google.protobuf", "com.linkedin.feathr.com.google.protobuf"
}
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
version=1.0.5-rc3
version=1.0.5-rc4
SONATYPE_AUTOMATIC_RELEASE=true
POM_ARTIFACT_ID=feathr_2.12

0 comments on commit 52658eb

Please sign in to comment.