Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dkist downstream test #1896

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix dkist downstream test #1896

merged 1 commit into from
Jan 23, 2025

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Jan 22, 2025

The dkist downstream job is failing:
https://github.com/asdf-format/asdf/actions/runs/12910632436/job/36001118249#step:10:493

This is due to the current test configuration being incompatible with the ignores in the dkist pytest.ini configuration file (the tests are run in ./dkist but the configuration assumes the tests are run in ./).

This PR updates the dkist downstream CI to be compatible with the dkist pytest configuration.

Tasks

  • run pre-commit on your machine
  • run pytest on your machine
  • Does this PR add new features and / or change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update relevant docstrings and / or docs/ page
    • for any new features, add unit tests
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: bug fix
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@braingram braingram marked this pull request as ready for review January 22, 2025 16:28
@braingram braingram requested a review from a team as a code owner January 22, 2025 16:28
@braingram braingram requested a review from Cadair January 22, 2025 16:28
@Cadair
Copy link
Contributor

Cadair commented Jan 22, 2025

I don't think it's pyargs, we skip that folder in our pytest config? https://github.com/DKISTDC/dkist/blob/main/pytest.ini#L16

@braingram
Copy link
Contributor Author

I don't think it's pyargs, we skip that folder in our pytest config? https://github.com/DKISTDC/dkist/blob/main/pytest.ini#L16

Weird. pytest finds that config file and just seems to ignore the ignore:
https://github.com/asdf-format/asdf/actions/runs/12910632436/job/36001118249#step:10:488

@braingram
Copy link
Contributor Author

I don't think it's pyargs, we skip that folder in our pytest config? https://github.com/DKISTDC/dkist/blob/main/pytest.ini#L16

I'm not sure why pytest isn't considering norecursedir to be relative to the pytest.ini but changing the downstream tests to run from the root of the dkist clone seems to fix the issue. Thanks @Cadair for the tip about the ignore being in pytest.ini.

@braingram braingram changed the title test dkist using pyargs fix dkist downstream test Jan 22, 2025
@braingram braingram merged commit a0898c2 into asdf-format:main Jan 23, 2025
47 of 48 checks passed
@braingram braingram deleted the fix_dkist branch January 23, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants