Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sort #106

Merged
merged 5 commits into from
Jan 6, 2025
Merged

feat: sort #106

merged 5 commits into from
Jan 6, 2025

Conversation

barnabasJ
Copy link
Contributor

@barnabasJ barnabasJ commented Jan 6, 2025 •
edited
Loading

Contributor checklist

  • Bug fixes include regression tests
  • Features include unit/acceptance tests

@barnabasJ barnabasJ self-assigned this Jan 6, 2025
@barnabasJ barnabasJ added the enhancement New feature or request label Jan 6, 2025
@zachdaniel
Copy link
Contributor

LGTM. Seems hard to test 😆

@barnabasJ barnabasJ changed the title Feat/sort feat: sort Jan 6, 2025
@barnabasJ barnabasJ marked this pull request as ready for review January 6, 2025 22:57
@barnabasJ barnabasJ merged commit dd22a12 into main Jan 6, 2025
18 checks passed
@barnabasJ barnabasJ deleted the feat/sort branch January 6, 2025 22:58
zachdaniel
zachdaniel reviewed Jan 6, 2025
View reviewed changes
test/ash_oban_test.exs
triggered2 =
Ash.reload!(triggered2)

assert DateTime.before?(triggered1.updated_at, triggered2.updated_at)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess it wasn't hard to test after all 🤦 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees

@barnabasJ barnabasJ

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barnabasJ @zachdaniel