Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add list tenants option #109

Merged
merged 5 commits into from
Jan 13, 2025
Merged

feat: add list tenants option #109

merged 5 commits into from
Jan 13, 2025

Conversation

barnabasJ
Copy link
Contributor

@barnabasJ barnabasJ commented Jan 13, 2025 •
edited
Loading

Contributor checklist

  • Bug fixes include regression tests
  • Features include unit/acceptance tests

If this reflects what we discussed last week, I'll try to add a test.

@barnabasJ barnabasJ added the enhancement New feature or request label Jan 13, 2025
@barnabasJ barnabasJ self-assigned this Jan 13, 2025
@barnabasJ barnabasJ requested a review from zachdaniel January 13, 2025 12:44
zachdaniel
zachdaniel approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@zachdaniel zachdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, a test would be great. Can use attribute multi tenancy.

@barnabasJ barnabasJ marked this pull request as ready for review January 13, 2025 13:34
@barnabasJ barnabasJ requested a review from zachdaniel January 13, 2025 13:35
@zachdaniel zachdaniel merged commit 98d614a into main Jan 13, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees

@barnabasJ barnabasJ

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barnabasJ @zachdaniel