Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Nimble.Expression to correct xcode 16 beta build issue #282

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

Ripcord715
Copy link

This should resolve the build errors I received when trying to test my snapshots on the xcode 16 beta 3 version. I was not able to confirm this myself because trying to point my SPM at my local branch of Nimble-Snapshots caused my xcode to crash. This could just be my inexperience with SPM and xcode, not setting it up correctly, but I wanted to make sure this was reviewed. Apologies for any inconvenience.

Copy link
Owner

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The Danger failure is unrelated to your PR, and the build looks successful. Let’s merge and I’ll get this released. Thanks again!

@ashfurrow ashfurrow merged commit b8d7899 into ashfurrow:master Aug 11, 2024
1 of 2 checks passed
@ashfurrow-peril
Copy link

Thanks a lot for contributing @Ripcord715! You've been invited to be a collaborator on this repo – no pressure to accept! If you'd like more information on what this means, check out the Moya contributor guidelines and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@ashfurrow
Copy link
Owner

Thanks again @Ripcord715, this was just released as 9.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants