Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡⏾: Dark and light mode features enabled in UI #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

subigya-js
Copy link

@subigya-js subigya-js commented Jan 18, 2025

In this PR, I have enabled light mode and dark mode feature in the ui. Also i have created a separate component directory where repeatedly used components will be stored.

package-lock.json Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/components/Navbar.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/index.css Outdated Show resolved Hide resolved
@subigya-js subigya-js requested a review from puncoz January 19, 2025 08:39
@puncoz
Copy link

puncoz commented Jan 20, 2025

@subigya-js looks good now....

aba kei minor improvement gara and its done:

  1. rename contexts directory to providers, and DarkModeContext.tsx to DarkModeProvider.tsx

  2. move ThemeToggleButton.tsx to components directory (or components/ui is also fine)

Copy link

@puncoz puncoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants