chore(copybara): sync commits from Aspect-internal silo #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitOrigin-RevId: 26bb9d9c5b6b51363ebba0d10059bbc03a154ad1
…(#3773)
This would have been helpful for me today to remember the `{dirname}`
variable 😅
### Type of change
- Documentation (updates to documentation or READMEs)
### Test plan
- Covered by existing test cases
GitOrigin-RevId: 4d90baec8c825d6beb0e87cd673fa02b0a90d328
I simply `bazel run tools:format`. Also upgrade rules_lint to latest --- ### Type of change - Style (white-space, formatting, etc...) ### Test plan Will be covered when we add a format-check step in our workflows setup. GitOrigin-RevId: a0673c22b876f5d7fa931cc40341c21c8e1219db
### Type of change - Chore (any other change that doesn't affect source or test files, such as configuration) GitOrigin-RevId: dcf9d346b2345760f6b2e90071a66444e6030e21
### Type of change - Bug fix (change which fixes an issue) - Chore (any other change that doesn't affect source or test files, such as configuration) ### Test plan - Covered by existing test cases - Manual testing; please provide instructions so we can reproduce: GitOrigin-RevId: 40732bccbda3ec783dcc3c01f889270bf588c698
Adds the missing `config` command to the CLI. It should be hidden, but when it's set to hidden, Cobra is seemingly confused and suggests that we want to run `configure` instead. --- ### Type of change - New feature or functionality (change which adds functionality) **For changes visible to end-users** - Relevant documentation has been updated - Suggested release notes are provided below: Add the Bazel `config` command to the Aspect CLI. ### Test plan - Manual testing; please provide instructions so we can reproduce: Run the built binary, can now run the `config` command. GitOrigin-RevId: 9098c884fe3949ec31d119207f63f45c6c104383
### Type of change - Bug fix (change which fixes an issue) ### Test plan - Manual testing; please provide instructions so we can reproduce: GitOrigin-RevId: f0e4b45f82d8e73ebf8aab5b0d591cd310c94b33
…urce (#3924) GitOrigin-RevId: 1050a5238fcd3dd9860e640de7628999c4e72a7a
Adds the gazelle cli `--mode` to the aspect cli Close #3906 ### Type of change - New feature or functionality (change which adds functionality) **For changes visible to end-users** - Relevant documentation has been updated (cli help command) ### Test plan Manual testing: run the compiled cli binary with `--mode=fix|diff|print` GitOrigin-RevId: c257635ae1ccc5c22893342f2270a2618a0f86ac
GitOrigin-RevId: d215e3c381c3498bff1d33c53806ee8ceeb5e227
GitOrigin-RevId: f2e0e86c9d5b5a9ceceb9451ef4a6fab97f7de35
GitOrigin-RevId: 7a0d494caf2027b8d3130bdff88eeab67a3ed22b
alexeagle
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/b298127493635001d51aae56e6ccf88be36bd538..26bb9d9c5b6b51363ebba0d10059bbc03a154ad1