chore: don't kick off github actions jobs for unchanged nested Bazel modules #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alexeagle
force-pushed
the
skipci
branch
28 times, most recently
from
d34d42d to
f90a0f3
Compare
alexeagle
force-pushed
the
skipci
branch
4 times, most recently
from
4515a94 to
74ad5a8
Compare
alexeagle
changed the title
kormide
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves us some GitHub Actions resource limit exhaustion, especially since we'll recommend that users send PRs here to play with Marvin.
It avoids them getting spammed with a dozen irrelevant github statuses here as well. This was a problem when I gave a demo today: had to scroll down to find the Aspect Workflows status.
Note: this affects lands to
mainas well. That means a nested module may be red at HEAD, but subsequent test runs don't re-test it and go back to green again. In a real user repository this would probably not be desirable behavior.Changes are visible to end-users: no
Test plan
Try changing some files in this PR and see what matrix jobs run