Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update bazel #379

Merged
merged 2 commits into from
Dec 3, 2024
Merged

chore: update bazel #379

merged 2 commits into from
Dec 3, 2024

Conversation

alexeagle
Copy link
Member

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@alexeagle alexeagle requested a review from kylecordes December 3, 2024 00:18
@aspect-workflows Aspect Workflows
Copy link
Contributor

aspect-workflows bot commented Dec 3, 2024 •
edited
Loading

Test

All tests were cache hits

25 tests (100.0%) were fully cached saving 11s.

Format      Lint

@alexeagle alexeagle enabled auto-merge (squash) December 3, 2024 14:19
kylecordes
kylecordes approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@kylecordes kylecordes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexeagle @kylecordes
chore: update bazel
4a4c895 
Also make more clear that WORKSPACE files can go away
@alexeagle @kylecordes
ignore module lockfile for formatting
cefe058
@alexeagle alexeagle merged commit c4be99f into main Dec 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecordes kylecordes kylecordes approved these changes

@JesseTatasciore JesseTatasciore Awaiting requested review from JesseTatasciore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @kylecordes